util: show all dirty status indicators#349
Closed
vegerot wants to merge 2 commits intofacebook:mainfrom
Closed
Conversation
Closed
370e3d7 to
52960be
Compare
Contributor
Author
|
This PR got borked somehow :/ #350 |
56e71e0 to
b84d503
Compare
Summary: Add shell prompt for Sapling. The current prompt only supports git and hg, but not sl. Since the `hg` prompt should work the same for `sl`, use `_hg_prompt` for Sapling if a `.sl` directory exists Test Plan: Blocked by facebook#447 TODO: copy `.hg` testcases from `eden/scm/tests/test-fb-ext-scm-prompt-hg.t`
Contributor
|
@vegerot I can close this one, right? |
Contributor
Author
|
@bolinfest you can close it if you don't want this feature 🙂 The PR message got messed up because of #350. I manually copy/pasted the commit info into the PR. At least I would like to see the first commit in this stack merged in #348 |
Summary: Instead of just showing `?` or `*`, show one of each symbol in the dirty status. This means there will be a maximum of 5 characters at the end of the prompt, which is fine. Test Plan: blocked by facebook#447 Question for reviewer: I am having trouble running the test suite for Sapling. I'd appreciate some help getting this working. I can provide more details if you wouldn't mind helping
Contributor
|
@quark-zju has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
Summary: util: add zsh prompt Add shell prompt for Sapling. The current prompt only supports git and hg, but not sl. Since the `hg` prompt should work the same for `sl`, use `_hg_prompt` for Sapling if a `.sl` directory exists Pull Request resolved: #348 Test Plan: Blocked by #447 TODO: copy `.hg` testcases from `eden/scm/tests/test-fb-ext-scm-prompt-hg.t` --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/348). * #349 * __->__ #348 Reviewed By: genevievehelsel Differential Revision: D43326422 Pulled By: quark-zju fbshipit-source-id: 3ceaf037ce62a06455c60a7e3669ec99c9428c5d
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
Summary: Pull Request resolved: facebook/mvfst#349 Reviewed By: vitaut Differential Revision: D60154344 fbshipit-source-id: dfadbf0a7e01867875c00b244857a560bc3497ad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Instead of just showing
?or*, show one of each symbol in thedirty status. This means there will be a maximum of 5 characters at the end of
the prompt, which is fine.
Test Plan: blocked by #447
Question for reviewer: I am having trouble running the test suite for Sapling.
I'd appreciate some help getting this working. I can provide more details if
you wouldn't mind helping